Fix PersonalityInsightsV3 problem "accept:text/csv" is not reflected#346
Merged
germanattanasio merged 3 commits intowatson-developer-cloud:masterfrom Feb 2, 2018
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
=======================================
Coverage 38.29% 38.29%
=======================================
Files 24 24
Lines 8706 8706
=======================================
Hits 3334 3334
Misses 5372 5372
Continue to review full report at Codecov.
|
Contributor
Author
|
I just signed CLA.
|
Contributor
|
Thanks for the PR @birdtomita! It looks good. |
Contributor
Author
|
I have to write a test code! I forgot. I will update it around 10 hours
later because it is already midnight in Japan.
|
Contributor
Author
|
I was watching the source trying to write the test code but is the test
code called test_json_to_csv () wrong?
Can I modify this?
A method for CSV validation could not be found in this library but is it
somewhere?
|
Contributor
|
@birdtomita sorry for the delay we will try to get to this PR this week |
Contributor
Author
|
thanks
2018-02-03 6:14 GMT+09:00 German Attanasio <notifications@github.com>:
… Merged #346
<#346>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#346 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPOTzpAyPN8kRW23ukUVh7Pz_AP73brks5tQ3qbgaJpZM4Ro7_9>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Merge this,
fix Personality Insights parameter "accept" was not reflected